Only one in-package per file

[wolf] / src / main / checker.lisp

diff --git a/src/main/checker.lisp b/src/main/checker.lisp
index 769ec3f4c98886625d6c182ef2d1371424447b18..a9c4082dad19d2558eb8ed18baac2f71f4958d8a 100644 (file)
--- a/src/main/checker.lisp
+++ b/src/main/checker.lisp
@@ -2,15 +2,16 @@
 
 ; Rules
 ; - Elements in each form must be indented the same amount
-; - No form longer than 50 lines
+; * No form longer than 50 lines
 ; - Top level multiline forms must be separated by exactly one space
-; - No line longer than 120 characters
+; * No line longer than 120 characters
 ; - No use of unexported symbols in other packages
 ; - No tabs
 ; - Only one space between elements in a form on a single line
-; - in-package must be first line in file unless file is package.lisp
+; * in-package must be first line in file unless file is package.lisp
 ; - No whitespace only lines
 ; - No empty lines at end of file
+; * Only one in-package per file
 ;
 ; Some thoughts
 ; - form starting reader macros will have to be hand added to this code
@@ -25,16 +26,23 @@
 (defvar *line-no* nil)
 (defvar *col-no* nil)
 (defvar *evaluators* nil)
+(defvar *form-stack* nil)
+
+(eval-when (:compile-toplevel :load-toplevel :execute)
+ (defparameter *possible-states*
+  '(:begin ; start of file
+    :normal ; normal processing
+   )))
+
 
 (defun set-state (state)
- (when (not (find state (list :begin ; start of file
-                              :normal
-                        )))
+ (when (not (find state *possible-states*))
   (error "Can't set state to ~A" state))
  (setf *state* state)
  nil)
 
 (defmacro defevaluator (state match func)
+ (when (not (find state *possible-states*)) (error "~A is an invalid state" state))
  (let
   ((scanner (gensym)))
  `(let
@@ -55,7 +63,11 @@
     *evaluators*))))
 
 (defun evaluate (text)
-; (if (string= "" text)
+ (if (string= "" text)
+     (let*
+      ((evaluator (find-if (lambda (f) (funcall f *state* :eof)) *evaluators* :from-end t :key #'car))
+       (problem (when evaluator (funcall (third evaluator)))))
+      (when problem (error (make-condition 'check-failure :msg problem :line-no *line-no* :col-no *col-no*))))
      (let
       ((evaluator (find-if (lambda (f) (funcall f *state* text)) *evaluators* :from-end t :key #'car)))
       (when (not evaluator) (error (make-condition 'check-failure :msg (format nil "Can't check in state ~S: ~S..." *state* (subseq text 0 (min (length text) 10))) :line-no *line-no* :col-no *col-no*)))
@@ -65,8 +77,8 @@
        (let
         ((length-of-match (funcall (cadr evaluator) text)))
         (incf *col-no* length-of-match)
-        (when (< 120 *col-no*) (error (make-condition 'check-failure :msg "Line longer than 120 characters" :line-no *line-no* :col-no *col-no*)))
-        (evaluate (subseq text length-of-match))))));)
+        (when (< 120 *col-no*) (error (make-condition 'check-failure :msg "Line longer than 120 characters" :line-no *line-no* :col-no 0)))
+        (evaluate (subseq text length-of-match)))))))
 
 (defun slurp-file (filename &key (element-type 'character) (sequence-type 'string))
  (with-open-file (str filename :element-type element-type)
@@ -76,20 +88,44 @@
  (set-state :begin)
  (setf *line-no* 0)
  (setf *col-no* 0)
+ (format t "~%File: ~A~%" file)
  (handler-case
   (progn (evaluate (slurp-file file)) t)
   (check-failure (cf)
-   (format t "In file ~A, Had an error: ~S at ~A:~A~%" (check-failure-msg cf) (check-failure-line-no cf) (check-failure-col-no cf))
+   (format t " - Had an error: ~S at ~A:~A~%" (check-failure-msg cf) (check-failure-line-no cf) (check-failure-col-no cf))
    nil)))
 
 (defun check-directory (dir)
  (every #'identity (mapcar #'check-file (directory (format nil "~A/**/*.lisp" dir)))))
 
+; These are in reverse order
 (progn
  (setf *evaluators* nil)
  (defevaluator :begin "\\(in-package[^\\)]*\\)"
   (lambda ()
    (set-state :normal) nil))
  (defevaluator :begin ".*"
+  (constantly "Must begin with in-package form"))
+ (defevaluator :normal "\\( *in-package "
+  (constantly "Only one in-package per file"))
+ (defevaluator :normal "\\n"
+  (lambda ()
+   (incf *line-no*)
+   (setf *col-no* 0)
+   nil))
+ (defevaluator :normal "\\("
   (lambda ()
-   "Must begin with in-package form")))
+   (push
+    (list *line-no* *col-no*)
+    *form-stack*)
+   nil))
+ (defevaluator :normal "\\)"
+  (lambda ()
+   (let
+    ((form (pop *form-stack*)))
+    (cond
+     ((not form) "Unmatched ending paren")
+     ((< 50 (- *line-no* (car form))) "Forms can't be over 50 lines long")))))
+
+ (defevaluator :normal "." (constantly nil))
+ )